Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add funnel arg to rel_to_df.duckdb_relation() #534

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 30, 2025

No description provided.

@krlmlr krlmlr changed the title f rel to df feat: Add funnel arg to rel_to_df.duckdb_relation() Jan 30, 2025
@krlmlr krlmlr enabled auto-merge (squash) January 30, 2025 16:21
@krlmlr krlmlr changed the title feat: Add funnel arg to rel_to_df.duckdb_relation() feat: Add funnel arg to rel_to_df.duckdb_relation() Jan 30, 2025
@krlmlr krlmlr merged commit 94bd3ed into main Jan 30, 2025
6 checks passed
@krlmlr krlmlr deleted the f-rel-to-df branch January 30, 2025 16:33
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if d5979b3 is merged into main:

  • ✔️001_tpch_01: 21.8ms -> 21.8ms [-4.51%, +4.18%]
  • ✔️001_tpch_02: 62.2ms -> 62.1ms [-0.95%, +0.67%]
  • ✔️001_tpch_03: 37.1ms -> 37.4ms [-0.1%, +2.01%]
  • ❗🐌001_tpch_04: 21.1ms -> 21.6ms [+0.25%, +4.58%]
  • ✔️001_tpch_05: 55.3ms -> 55.8ms [-0.18%, +2.07%]
  • ✔️001_tpch_06: 16.9ms -> 17.2ms [-0.3%, +3.52%]
  • ✔️001_tpch_07: 69.5ms -> 69.9ms [-0.51%, +1.67%]
  • ❗🐌001_tpch_08: 89.2ms -> 90.3ms [+0.05%, +2.41%]
  • ✔️001_tpch_09: 71.3ms -> 72ms [-0.44%, +2.43%]
  • ✔️001_tpch_10: 46.6ms -> 47ms [-0.17%, +2.11%]
  • ✔️001_tpch_11: 30.3ms -> 30.5ms [-0.08%, +1.48%]
  • ✔️001_tpch_12: 20.6ms -> 20.9ms [-2.6%, +4.9%]
  • ✔️001_tpch_13: 23.5ms -> 23.7ms [-0.97%, +3.05%]
  • ✔️001_tpch_14: 22.5ms -> 22.5ms [-2.66%, +2.88%]
  • ✔️001_tpch_15: 28.4ms -> 28.7ms [-0.38%, +2.79%]
  • ✔️001_tpch_16: 28.2ms -> 28.7ms [-1.63%, +4.79%]
  • ✔️001_tpch_17: 23.9ms -> 24ms [-0.51%, +1.43%]
  • ✔️001_tpch_18: 21.6ms -> 21.8ms [-2.09%, +3.73%]
  • ✔️001_tpch_19: 43.4ms -> 43.7ms [-0.44%, +1.81%]
  • ❗🐌001_tpch_20: 42.3ms -> 42.7ms [+0.22%, +1.77%]
  • ✔️001_tpch_21: 74.9ms -> 76ms [-0.35%, +3.09%]
  • ✔️001_tpch_22: 44ms -> 44.1ms [-0.85%, +1.28%]
  • ✔️010_tpch_01: 78.8ms -> 76.8ms [-10.18%, +4.98%]
  • ✔️010_tpch_02: 67.5ms -> 68.2ms [-0.12%, +2.19%]
  • ✔️010_tpch_03: 55.7ms -> 56.2ms [-2.77%, +4.35%]
  • ✔️010_tpch_04: 40.9ms -> 41.4ms [-1.46%, +4.27%]
  • ✔️010_tpch_05: 86.3ms -> 85.7ms [-2.82%, +1.27%]
  • ✔️010_tpch_06: 28.5ms -> 30.2ms [-2.72%, +14.47%]
  • ✔️010_tpch_07: 97.9ms -> 99.2ms [-0.55%, +3.19%]
  • ✔️010_tpch_08: 122ms -> 123ms [-1.62%, +2.95%]
  • ✔️010_tpch_09: 112ms -> 113ms [-0.22%, +2.47%]
  • ✔️010_tpch_10: 70.5ms -> 71.1ms [-0.62%, +2.33%]
  • ✔️010_tpch_11: 35.6ms -> 36.7ms [-1.2%, +7.17%]
  • ✔️010_tpch_12: 50.8ms -> 50.2ms [-4.54%, +2.2%]
  • ✔️010_tpch_13: 49.6ms -> 50.4ms [-1.01%, +4.36%]
  • ✔️010_tpch_14: 33.9ms -> 32.9ms [-7%, +0.68%]
  • ✔️010_tpch_15: 50.1ms -> 50.5ms [-5.31%, +7.01%]
  • ✔️010_tpch_16: 37.3ms -> 37.5ms [-1.49%, +2.75%]
  • ✔️010_tpch_17: 50.9ms -> 51.7ms [-2.83%, +5.96%]
  • ✔️010_tpch_18: 49.8ms -> 51.7ms [-2.94%, +10.85%]
  • ✔️010_tpch_19: 82.4ms -> 82.3ms [-1.03%, +0.8%]
  • ✔️010_tpch_20: 62.8ms -> 63ms [-3.68%, +4.14%]
  • ✔️010_tpch_21: 235ms -> 230ms [-4.09%, +0.18%]
  • ✔️010_tpch_22: 50.6ms -> 50.7ms [-1.89%, +2.43%]
  • ✔️100_tpch_01: 323ms -> 338ms [-7.36%, +16.71%]
  • ✔️100_tpch_02: 129ms -> 120ms [-21.77%, +7.99%]
  • ✔️100_tpch_03: 166ms -> 173ms [-2.27%, +10.57%]
  • ✔️100_tpch_04: 151ms -> 147ms [-6.06%, +0.7%]
  • ❗🐌100_tpch_05: 249ms -> 269ms [+1.4%, +15.1%]
  • ✔️100_tpch_06: 90.8ms -> 98.6ms [-26.23%, +43.52%]
  • ✔️100_tpch_07: 220ms -> 220ms [-6.13%, +5.79%]
  • ✔️100_tpch_08: 261ms -> 258ms [-5.34%, +3.05%]
  • ❗🐌100_tpch_09: 316ms -> 343ms [+3.36%, +13.77%]
  • ✔️100_tpch_10: 208ms -> 200ms [-13.23%, +6%]
  • ✔️100_tpch_11: 85.7ms -> 81.2ms [-19.18%, +8.86%]
  • ✔️100_tpch_12: 183ms -> 178ms [-22.35%, +16.2%]
  • ✔️100_tpch_13: 303ms -> 307ms [-1.49%, +4.57%]
  • ✔️100_tpch_14: 114ms -> 113ms [-29.31%, +27.81%]
  • ✔️100_tpch_15: 198ms -> 196ms [-9.16%, +6.58%]
  • ✔️100_tpch_16: 120ms -> 119ms [-11.92%, +9.92%]
  • ✔️100_tpch_17: 174ms -> 186ms [-3.6%, +16.98%]
  • ✔️100_tpch_18: 197ms -> 188ms [-12.82%, +3.57%]
  • ✔️100_tpch_19: 273ms -> 253ms [-19.99%, +5.18%]
  • ✔️100_tpch_20: 173ms -> 167ms [-10.24%, +3.55%]
  • ✔️100_tpch_21: 1.29s -> 1.31s [-4.08%, +7.71%]
  • ✔️100_tpch_22: 145ms -> 148ms [-0.62%, +5.62%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant