Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename funnel to inert #529

Closed
wants to merge 3 commits into from
Closed

feat: Rename funnel to inert #529

wants to merge 3 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 29, 2025

Closes #511.

@krlmlr krlmlr changed the title f 511 inert check_inertia() Jan 29, 2025
@krlmlr krlmlr enabled auto-merge (squash) January 29, 2025 15:09
@krlmlr krlmlr changed the title check_inertia() feat: Rename funnel to inert Jan 29, 2025
@krlmlr krlmlr marked this pull request as draft January 29, 2025 15:09
auto-merge was automatically disabled January 29, 2025 15:09

Pull request was converted to draft

@krlmlr krlmlr requested a review from hadley January 29, 2025 15:10
@krlmlr krlmlr closed this Jan 29, 2025
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0d7706d is merged into main:

  • ✔️001_tpch_01: 21.1ms -> 20.9ms [-6.35%, +4.64%]
  • ✔️001_tpch_02: 60.8ms -> 61.3ms [-0.48%, +2.01%]
  • ✔️001_tpch_03: 37.6ms -> 37.1ms [-3.16%, +0.1%]
  • ✔️001_tpch_04: 21.7ms -> 21.5ms [-2.82%, +0.49%]
  • ✔️001_tpch_05: 56.4ms -> 56.6ms [-1.73%, +2.5%]
  • ✔️001_tpch_06: 16.5ms -> 16.5ms [-2.75%, +2.18%]
  • ✔️001_tpch_07: 66.8ms -> 67.7ms [-0.33%, +3.07%]
  • ✔️001_tpch_08: 88.2ms -> 87.6ms [-1.76%, +0.38%]
  • ✔️001_tpch_09: 71.3ms -> 71.1ms [-1.66%, +0.98%]
  • ✔️001_tpch_10: 45.6ms -> 45.4ms [-1.42%, +0.36%]
  • ✔️001_tpch_11: 29.9ms -> 29.7ms [-1.4%, +0.43%]
  • ✔️001_tpch_12: 20.3ms -> 20.6ms [-1.46%, +4.19%]
  • ✔️001_tpch_13: 23.3ms -> 23.2ms [-3.58%, +2.91%]
  • ✔️001_tpch_14: 21.9ms -> 21.6ms [-3.85%, +1.22%]
  • ✔️001_tpch_15: 28.3ms -> 28.5ms [-1.15%, +2.67%]
  • ✔️001_tpch_16: 28.4ms -> 28ms [-3.09%, +0.37%]
  • ✔️001_tpch_17: 23.8ms -> 24.1ms [-0.53%, +2.54%]
  • ✔️001_tpch_18: 21.1ms -> 21.1ms [-2.11%, +2.08%]
  • ✔️001_tpch_19: 42.7ms -> 42.8ms [-1.55%, +1.66%]
  • ✔️001_tpch_20: 41.8ms -> 42.1ms [-0.9%, +2.68%]
  • ✔️001_tpch_21: 74.1ms -> 73.7ms [-2.52%, +1.43%]
  • ✔️001_tpch_22: 43.2ms -> 42.6ms [-3.53%, +0.6%]
  • ✔️010_tpch_01: 77.5ms -> 78.2ms [-2.75%, +4.67%]
  • ✔️010_tpch_02: 70ms -> 68.7ms [-5.12%, +1.37%]
  • ✔️010_tpch_03: 56.2ms -> 55.6ms [-2.76%, +0.56%]
  • ✔️010_tpch_04: 41ms -> 41.7ms [-0.64%, +4%]
  • ✔️010_tpch_05: 86.4ms -> 85ms [-5.34%, +2.14%]
  • ✔️010_tpch_06: 29.7ms -> 29.7ms [-9.93%, +10.26%]
  • ✔️010_tpch_07: 101ms -> 100ms [-3.03%, +1.38%]
  • ✔️010_tpch_08: 122ms -> 123ms [-0.99%, +2.23%]
  • ✔️010_tpch_09: 112ms -> 113ms [-3.04%, +5.99%]
  • ✔️010_tpch_10: 73.9ms -> 73.6ms [-5.6%, +4.94%]
  • ✔️010_tpch_11: 36.2ms -> 36.3ms [-4.56%, +5.12%]
  • ✔️010_tpch_12: 50.6ms -> 50.1ms [-7.06%, +5.17%]
  • ✔️010_tpch_13: 51.3ms -> 49.5ms [-8.9%, +1.91%]
  • ✔️010_tpch_14: 33.7ms -> 33.6ms [-1.9%, +1.36%]
  • ✔️010_tpch_15: 49ms -> 50.5ms [-3.4%, +9.36%]
  • ✔️010_tpch_16: 38.4ms -> 38.3ms [-4.88%, +4.52%]
  • ✔️010_tpch_17: 52.4ms -> 51.3ms [-6.1%, +2.05%]
  • ✔️010_tpch_18: 52.8ms -> 55.2ms [-1.67%, +10.77%]
  • ✔️010_tpch_19: 82.8ms -> 82.1ms [-4.47%, +2.6%]
  • ✔️010_tpch_20: 61.5ms -> 62ms [-4.13%, +5.97%]
  • ✔️010_tpch_21: 229ms -> 227ms [-3.42%, +1.25%]
  • ✔️010_tpch_22: 50.9ms -> 49.9ms [-4.71%, +0.82%]
  • ✔️100_tpch_01: 316ms -> 296ms [-24.02%, +11.73%]
  • ✔️100_tpch_02: 123ms -> 132ms [-1.98%, +17.5%]
  • ✔️100_tpch_03: 168ms -> 181ms [-8.4%, +24.18%]
  • ✔️100_tpch_04: 146ms -> 148ms [-2.37%, +5.77%]
  • ❗🐌100_tpch_05: 260ms -> 282ms [+1.27%, +15.6%]
  • ✔️100_tpch_06: 100ms -> 93.1ms [-22.33%, +8.39%]
  • ✔️100_tpch_07: 218ms -> 217ms [-8.34%, +7.17%]
  • ❗🐌100_tpch_08: 249ms -> 266ms [+0.55%, +12.41%]
  • ✔️100_tpch_09: 323ms -> 324ms [-8.74%, +9.15%]
  • ✔️100_tpch_10: 211ms -> 213ms [-4.98%, +6.69%]
  • ✔️100_tpch_11: 80.9ms -> 87ms [-13.88%, +28.97%]
  • ✔️100_tpch_12: 179ms -> 186ms [-7.24%, +15.48%]
  • ✔️100_tpch_13: 342ms -> 329ms [-16.54%, +8.87%]
  • ✔️100_tpch_14: 116ms -> 116ms [-9.86%, +9.53%]
  • ✔️100_tpch_15: 207ms -> 209ms [-3.13%, +4.73%]
  • ✔️100_tpch_16: 115ms -> 119ms [-0.32%, +7.53%]
  • ✔️100_tpch_17: 181ms -> 173ms [-14.72%, +5.56%]
  • ✔️100_tpch_18: 190ms -> 189ms [-12.93%, +12.35%]
  • 🚀100_tpch_19: 289ms -> 254ms [-18.67%, -5.4%]
  • ✔️100_tpch_20: 179ms -> 166ms [-16.8%, +2.65%]
  • ✔️100_tpch_21: 1.35s -> 1.32s [-9.85%, +5.26%]
  • ✔️100_tpch_22: 152ms -> 149ms [-9.31%, +5.7%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partial funneling sounds like real funneling
1 participant