Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change funnel values to "open" and "closed" instead of a logical value #526

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 29, 2025

For #511.

@krlmlr krlmlr force-pushed the f-511-open-closed branch from 14d00a7 to 783e80a Compare January 29, 2025 08:14
@krlmlr krlmlr merged commit 2343b7b into main Jan 29, 2025
21 checks passed
@krlmlr krlmlr deleted the f-511-open-closed branch January 29, 2025 08:33
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 783e80a is merged into main:

  • ✔️001_tpch_01: 21ms -> 21.6ms [-2.33%, +7.81%]
  • ✔️001_tpch_02: 61.6ms -> 60.9ms [-2.78%, +0.38%]
  • ✔️001_tpch_03: 36.9ms -> 36.6ms [-3.17%, +1.27%]
  • ✔️001_tpch_04: 21ms -> 20.9ms [-3.22%, +2.41%]
  • ✔️001_tpch_05: 54.5ms -> 54.8ms [-1.36%, +2.34%]
  • ✔️001_tpch_06: 16.3ms -> 16.5ms [-0.64%, +3.64%]
  • ✔️001_tpch_07: 68.2ms -> 68.7ms [-0.28%, +1.54%]
  • ✔️001_tpch_08: 88.7ms -> 89ms [-0.91%, +1.6%]
  • ✔️001_tpch_09: 71.1ms -> 71ms [-1.13%, +1.09%]
  • ✔️001_tpch_10: 46.7ms -> 46.2ms [-2.66%, +0.78%]
  • ✔️001_tpch_11: 30.3ms -> 30.5ms [-1.1%, +2.82%]
  • ✔️001_tpch_12: 20.4ms -> 20.3ms [-2.42%, +1.71%]
  • ✔️001_tpch_13: 22.7ms -> 22.7ms [-1.48%, +1.56%]
  • ✔️001_tpch_14: 21.8ms -> 21.9ms [-2.22%, +3%]
  • ✔️001_tpch_15: 28ms -> 28.2ms [-1.3%, +2.18%]
  • ✔️001_tpch_16: 27.9ms -> 27.7ms [-3.37%, +2.11%]
  • ✔️001_tpch_17: 23.7ms -> 24ms [-0.49%, +2.92%]
  • ✔️001_tpch_18: 21.3ms -> 21.2ms [-2.84%, +1.82%]
  • ✔️001_tpch_19: 42.8ms -> 44.4ms [-3.81%, +11.33%]
  • ✔️001_tpch_20: 41.7ms -> 42.1ms [-0.26%, +2.44%]
  • ✔️001_tpch_21: 73.9ms -> 74.1ms [-0.48%, +1.27%]
  • ✔️001_tpch_22: 43.1ms -> 43.1ms [-1.09%, +1.24%]
  • ✔️010_tpch_01: 75.7ms -> 78.2ms [-1.83%, +8.21%]
  • ✔️010_tpch_02: 67.5ms -> 67.2ms [-1.68%, +0.89%]
  • ✔️010_tpch_03: 54.6ms -> 54.2ms [-1.79%, +0.57%]
  • ❗🐌010_tpch_04: 39.8ms -> 40.4ms [+0.34%, +3%]
  • ✔️010_tpch_05: 85.2ms -> 85.3ms [-1.46%, +1.83%]
  • ✔️010_tpch_06: 28.6ms -> 27.4ms [-8.88%, +0.78%]
  • ✔️010_tpch_07: 97.5ms -> 99.5ms [-2.5%, +6.51%]
  • ✔️010_tpch_08: 122ms -> 122ms [-3.31%, +2.91%]
  • ✔️010_tpch_09: 110ms -> 111ms [-0.35%, +2.22%]
  • ✔️010_tpch_10: 70.2ms -> 70.1ms [-2.54%, +2.18%]
  • ✔️010_tpch_11: 35.2ms -> 35.6ms [-2.25%, +4.99%]
  • ✔️010_tpch_12: 50.1ms -> 51.2ms [-4.85%, +9.11%]
  • ✔️010_tpch_13: 49ms -> 48.9ms [-1.04%, +0.84%]
  • ✔️010_tpch_14: 33ms -> 33ms [-4.64%, +4.76%]
  • ✔️010_tpch_15: 50.1ms -> 50.6ms [-5.57%, +7.36%]
  • ✔️010_tpch_16: 37.2ms -> 36.8ms [-3.72%, +1.59%]
  • ✔️010_tpch_17: 51.9ms -> 50.8ms [-8.89%, +4.53%]
  • ✔️010_tpch_18: 49.5ms -> 52ms [-2.24%, +12.71%]
  • ✔️010_tpch_19: 82.1ms -> 82.1ms [-1.26%, +1.05%]
  • ✔️010_tpch_20: 63.4ms -> 61.5ms [-8.77%, +2.87%]
  • ✔️010_tpch_21: 227ms -> 229ms [-1.77%, +3.28%]
  • ✔️010_tpch_22: 50.7ms -> 49.9ms [-3.47%, +0.23%]
  • ✔️100_tpch_01: 338ms -> 333ms [-7.56%, +4.45%]
  • ✔️100_tpch_02: 124ms -> 124ms [-4.26%, +4.59%]
  • ✔️100_tpch_03: 170ms -> 168ms [-4.8%, +2.47%]
  • ✔️100_tpch_04: 149ms -> 155ms [-8.33%, +16.57%]
  • ✔️100_tpch_05: 255ms -> 263ms [-8.35%, +14.73%]
  • ✔️100_tpch_06: 96ms -> 103ms [-13.67%, +27.68%]
  • ✔️100_tpch_07: 219ms -> 224ms [-3.12%, +7.52%]
  • ✔️100_tpch_08: 242ms -> 253ms [-3.57%, +12.98%]
  • ✔️100_tpch_09: 331ms -> 310ms [-18.15%, +5.19%]
  • ✔️100_tpch_10: 209ms -> 202ms [-11.83%, +5.13%]
  • ✔️100_tpch_11: 79.5ms -> 89.8ms [-6.86%, +32.74%]
  • ✔️100_tpch_12: 194ms -> 183ms [-25.31%, +13.82%]
  • ✔️100_tpch_13: 299ms -> 306ms [-7.69%, +12.45%]
  • ✔️100_tpch_14: 114ms -> 114ms [-9.77%, +9.33%]
  • ✔️100_tpch_15: 201ms -> 199ms [-11.11%, +9.57%]
  • ✔️100_tpch_16: 120ms -> 116ms [-6.8%, +0.75%]
  • ✔️100_tpch_17: 170ms -> 179ms [-9.38%, +19.89%]
  • ✔️100_tpch_18: 184ms -> 191ms [-7.03%, +14.68%]
  • ✔️100_tpch_19: 260ms -> 270ms [-6.07%, +14.08%]
  • ✔️100_tpch_20: 168ms -> 166ms [-11.59%, +8.95%]
  • ✔️100_tpch_21: 1.28s -> 1.27s [-6.36%, +5.1%]
  • ✔️100_tpch_22: 150ms -> 147ms [-7.55%, +3.27%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant