-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document .funnel
/funnel
argument
#513
Conversation
.funnel
/`funnel argument.funnel
/funnel
argument
This is how benchmark results would change (along with a 95% confidence interval in relative change) if a29e651 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -245,7 +245,7 @@ In dtplyr and dbplyr, there are no unfunneled frames: collection always needs to | |||
## Partial funneling | |||
|
|||
Partial funneling is a compromise between funneling and unfunneling. | |||
Materialization is allowed for data up to a certain size, measured in cells (values) or rows in the resulting data frame. | |||
Materialization is allowed for data up to a certain size, measured in cells (values) and rows in the resulting data frame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a detail but because of this and because of there being only examples with one or the other, I thought it was either or.
#' The default is to inherit the funneling of the input. | ||
#' see the "Funneling" section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that this section needs to go or be shortened drastically, pointing to the vignette.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You made a comment about this but I'll track it in an issue.
No description provided.