Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject maskable arguments in slice_*() #6726

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Inject maskable arguments in slice_*() #6726

merged 2 commits into from
Feb 15, 2023

Conversation

DavisVaughan
Copy link
Member

Closes #6725

@DavisVaughan DavisVaughan requested a review from hadley February 14, 2023 21:20
hadley
hadley approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@DavisVaughan DavisVaughan merged commit 37e4c6e into tidyverse:main Feb 15, 2023
@DavisVaughan DavisVaughan deleted the fix/slice-masking branch February 15, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slice_sample errors out if a column name in .data has the explicit name of replace
2 participants
@DavisVaughan @hadley