New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass correct `user_env` through to all `filter()` warnings #6706

Merged

DavisVaughan merged 2 commits into tidyverse:main from DavisVaughan:fix/filter-warning-user-env

Feb 9, 2023

Member

DavisVaughan commented Feb 9, 2023

Closes #6679

We weren't passing the user_env through to deprecate_warn() (probably because it didn't exist at the time).

The example from #6679 now reports the right package

df2 <- df |> tabyl(procedure_name)
#> Warning: Using one column matrices in `filter()` was deprecated in dplyr 1.1.0.
#> ℹ Please use one dimensional logical vectors instead.
#> ℹ The deprecated feature was likely used in the janitor package.
#>   Please report the issue at <https://github.com/sfirke/janitor/issues>.

DavisVaughan added 2 commits

February 9, 2023 17:03


          Pass correct user_env through to all filter() warnings

303ac9a


          NEWS bullet

fca06e5

DavisVaughan merged commit 49b39af into tidyverse:main

DavisVaughan deleted the fix/filter-warning-user-env branch

February 9, 2023 22:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet