Switch to radix ordering in more places #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Sep 8, 2022
DavisVaughan
force-pushed
the
feature/base-to-radix
branch
from
3ad94fb to
a011349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nth(order_by =)with_order()This means that
vec_order_base()is now only used in thedplyr.legacy_localecode path ofgroup_by(). And I might be able to remove that in another PR by usingdplyr_order_legacy(), which is used in thearrange()legacy path. I'll take a look.I did not feel like this needs a news bullet, because it is highly unlikely to affect much code, and we don't provide a way to opt out of this.