Extract mutate_col() from mutate_cols()
#6438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
force-pushed
the
simplify-mutate-cols
branch
from
54f8218 to
14688d9
Compare
DavisVaughan
approved these changes
Sep 2, 2022
R/mutate.R
Outdated
Comment on lines
237
to
238
| context_poke("column", old_current_column) | ||
| new_columns <- mutate_col(i, .data, dots, mask, new_columns) |
There was a problem hiding this comment.
I suppose you could do
dot <- dots[[I]]
new_columns <- mutate_col(.data, dot, mask, new_columns)That would really narrow the scope (i.e. mutate_col() doesn't need to know which iteration it is on, and it doesn't need all the dots, only the one it currently has to process)
It seems like you didn't change much code while extracting this out, which I appreciate because it made it easier to review 😄 but this might be worth it
There was a problem hiding this comment.
oops good catch, somehow I thought the function depended on its iteration number.
lionel-
force-pushed
the
simplify-mutate-cols
branch
from
14688d9 to
ff7bdfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the body of the
mutate_cols()loop into a separate function. This simplifies thewithCallingHandlers()call and it is easier to see what's going on in the handled expression and in the condition handlers. Also reduces nesting/indentation inside the body, making it easier to read.