Rework lag() and lead() onto a common shift() helper
#6336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
force-pushed
the
feature/lead-lag-update
branch
from
d82619c to
881fb14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6330
Using this as my starting point tidyverse/funs#34 (comment)
Main change in behavior is that now
defaultis cast to the type ofxrather than taking the common type. This ensures that these functions are type stable onx, which I feel like is a very important property here.These functions already used vctrs in some capacity, but I was able to optimize it a little by separating out cases where the
defaultis or is not supplied (when there is no default supplied, this is a simpler slice operation)."dfba9805-5c9b-47a0-813d-9c781aba4b63"