Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slice_sample() handling of n= and prop= #6172

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Fix slice_sample() handling of n= and prop= #6172

merged 2 commits into from
Feb 3, 2022

Conversation

romainfrancois
Copy link
Member

related to Nowosad/motif#66

@romainfrancois romainfrancois changed the title Fix slice_sample() handling of n= and prop= Fix slice_sample() handling of n= and prop= Feb 2, 2022
DavisVaughan
DavisVaughan reviewed Feb 2, 2022
View reviewed changes
R/slice.R Show resolved Hide resolved
DavisVaughan
DavisVaughan reviewed Feb 2, 2022
View reviewed changes
R/slice.R Outdated Show resolved Hide resolved
@romainfrancois
Copy link
Member Author

Thanks @DavisVaughan. I've fusion both functions, and removed the unnecessary min/max because the original slice() already takes care of silently truncating.

@romainfrancois romainfrancois merged commit b93d0c3 into main Feb 3, 2022
@romainfrancois romainfrancois deleted the slice_sample branch February 3, 2022 08:51
@romainfrancois romainfrancois mentioned this pull request Feb 3, 2022
Merged
@hadley hadley mentioned this pull request Apr 15, 2022
Closed
@eutwt eutwt mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavisVaughan DavisVaughan DavisVaughan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainfrancois @DavisVaughan