Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should with_groups() be deprecated in favor of .by argument? #6582

Closed
yutannihilation opened this issue Dec 2, 2022 · 1 comment · Fixed by #6608
Closed

Should with_groups() be deprecated in favor of .by argument? #6582

yutannihilation opened this issue Dec 2, 2022 · 1 comment · Fixed by #6608
Labels
documentation grouping 👨‍👩‍👧‍👦

Comments

@yutannihilation
Copy link
Member

In my understanding, most of the usages of with_groups() will be superseded by .by. Shouldn't it be marked as deprecated or superseded?
@hadley
Copy link
Member

hadley commented Dec 4, 2022

Yeah, I think we should supersede it. It's currently marked as experimental, so I think that's just a change to the docs.

hadley added a commit that referenced this issue Dec 15, 2022
@hadley
Superseded with_groups()
be75883 
Fixes #6582
@hadley hadley mentioned this issue Dec 15, 2022
Merged
hadley added a commit that referenced this issue Dec 16, 2022
@hadley
Doc tweaks for .by (#6608)
7d60f6f 
* Superseded with_groups(). Fixes #6582
* Use per-operation rather than temporary. Fixes #6585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation grouping 👨‍👩‍👧‍👦
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc tweaks for .by tidyverse/dplyr
2 participants
@hadley @yutannihilation