-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tbl_df example is now broken for Lahman 3.0 #586
Comments
I'm travelling at the moment, but I'll get fixed as soon as I can. |
Removing that variable fixes the first problem, but then the joins won't work with the current lahman release :/ |
Well, we're in a package-version-clash situation here. The CRAN people rejected the new version, on R-Forge |
Lahman 3.0-1 is on CRAN now and should propagate shortly. Can you install the new version |
Two changes are needed: (i) remove hofID in the call that produces player_info When I made those two changes, all of the joins worked in the latest version of the Lahman package. I'm using version 0.2 of dplyr for this test. I tried to do the same with the development version of dplyr but it failed to install...that's a separate and tangential issue, though. |
v 3.0-1 of the Lahman package entailed some changes in the names of ID variables:
Consequently, when submitted to CRAN, the following error is generated when checking dplyr:
The fix is to remove hofID from the call to
select
on line 53 of tbl_df.Rd-Michael
The text was updated successfully, but these errors were encountered: