Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault in left_join when factor levels not equal #1712

Closed
adibender opened this issue Mar 14, 2016 · 1 comment
Closed

Segfault in left_join when factor levels not equal #1712

adibender opened this issue Mar 14, 2016 · 1 comment
Assignees
@romainfrancois
Labels
bug an unexpected problem or unintended behavior
Milestone
0.5

Comments

@adibender
Copy link

adibender commented Mar 14, 2016 •
edited by romainfrancois
Loading

Similar to #371 (R --vanilla)

Minimal:

library(dplyr)
d1 <- iris[, c("Species", "Sepal.Length")]
d2 <- iris[, c("Species", "Sepal.Width")]
d2$Species <- factor(as.character(d2$Species), levels=rev(levels(d1$Species)))
left_join(d1, d2, by="Species")
@adibender adibender changed the title Segfault in left_join when factor levels not equal Segfault in left_join when factor levels not equal Mar 14, 2016
@hadley hadley added the bug an unexpected problem or unintended behavior label Apr 19, 2016
@hadley hadley added this to the 0.5 milestone Apr 19, 2016
@hadley
Copy link
Member

hadley commented Apr 19, 2016

@romainfrancois can you take a look at this too please?

romainfrancois added a commit that referenced this issue Apr 28, 2016
@romainfrancois
dealt with come back of #306 when fixing #1712
0db9c77
@romainfrancois romainfrancois mentioned this issue Apr 30, 2016
Closed
romainfrancois added a commit that referenced this issue Apr 30, 2016
@romainfrancois
inner_join was crashing R session. same undelrying issue as #1712. I …
5584280 
…just added a regression test. closes #1559
sicarul pushed a commit to sicarul/dplyr that referenced this issue May 4, 2016
@romainfrancois @sicarul
Fixed bug about joins when factor levels not equal. closes tidyverse#…
38a3152 
…1712
sicarul pushed a commit to sicarul/dplyr that referenced this issue May 4, 2016
@romainfrancois @sicarul
dealt with come back of tidyverse#306 when fixing tidyverse#1712
09400ff
sicarul pushed a commit to sicarul/dplyr that referenced this issue May 4, 2016
@romainfrancois @sicarul
inner_join was crashing R session. same undelrying issue as tidyverse…
8dd7d8a 
…#1712. I just added a regression test. closes tidyverse#1559
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@romainfrancois romainfrancois

Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
3 participants
@hadley @adibender @romainfrancois