Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up the
get_model_spec()
helper. I'm first just pushing some new tests so we can run checks and ensure that results don't change.This helper is called once per model specification fit (or translation).
As a percentage of total time, the helper takes a bit more than 6.5% of the evaluation time:
The rewritten version of the helper is below (just for purposes of self-contained reprex):
With benchmarks:
Note with
check = TRUE
in the above,mark()
checks equality of the outputs. :) The new check isas.numeric(bm2$median[1]) / as.numeric(bm2$median[2])
times faster than the old one:Created on 2023-03-06 with reprex v2.0.2
cc @DavisVaughan--thanks for the rewrite.🏄 Note that this reprex was generated with dev dplyr--quite a big speedup already with their changes.