Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use brulee::brulee_activations() to check for available activation functions in parsnip::check_args.mlp() #1019

Closed
christophscheuch opened this issue Nov 6, 2023 · 3 comments · Fixed by #1065
Labels
feature a feature request or enhancement

Comments

@christophscheuch
Copy link

A recent change in brulee introduced new activation functions and brulee_activations(), which provides available functions (see PR #74). However, parsnip does not support these new activation functions yet, because parsnip::check_args.mlp() has hard coded values (see function definition here).

Would be great to have support for the new activation functions in parsnip.

@hfrick hfrick added the feature a feature request or enhancement label Nov 6, 2023
@hfrick
Copy link
Member

hfrick commented Nov 6, 2023

Thanks for flagging this @christophscheuch ! We'll get this opened up once the dust of the current work on {brulee} by @topepo has settled a bit.

@topepo
Copy link
Member

topepo commented Feb 13, 2024

I am working on this now that I just sent brulee to CRAN (with those features).

topepo pushed a commit that referenced this issue Feb 14, 2024
topepo pushed a commit that referenced this issue Feb 14, 2024
topepo added a commit that referenced this issue Feb 14, 2024
* remove mlp activation check for #1019

* unit test for #1019

* update news

* version requirement in skip

---------

Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’>
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants