updated stretch to factor x and y columns by default #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #98 |
|
These checks did not fail when I ran R-CMD-check locally. |
|
Hi @juliasilge, It looks like you might be preparing to review this PR. Please let me know if there is anything that isn't clear or if there is anything else I can do to help. |
Merge branch 'master' into mattwarkentin-master # Conflicts: # R/cor_df.R # tests/testthat/stretch-keep.order_FALSE.txt # tests/testthat/test-stretch.R
|
Thank you so much @mattwarkentin! This is looking great. 🙌 We are going to have @thisisdaryn do a little review here in a bit with a few changes. |
|
No problem! Happy to help. |
thisisdaryn
reviewed
Jun 24, 2020
thisisdaryn
reviewed
Jun 24, 2020
thisisdaryn
approved these changes
Jun 25, 2020
This was referenced Jun 25, 2020
Closed
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.