Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sign(rdf) instead of sign(distance) in network_plot #89

Merged
merged 5 commits into from
Jun 15, 2020
Merged

Use sign(rdf) instead of sign(distance) in network_plot #89

merged 5 commits into from
Jun 15, 2020

Conversation

s-scherrer
Copy link
Contributor

This fixes issues when the correlation is exactly 1 or 0.
Fixes #88.

@juliasilge
Copy link
Member

Thanks so much for your patience with this PR @s-scherrer! 🙌

@juliasilge juliasilge merged commit 90541c4 into tidymodels:master Jun 15, 2020
@s-scherrer s-scherrer deleted the sign-network-plot branch June 15, 2020 07:27
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sign issues in network_plot
2 participants