Fix butchering for parsnip's bart()
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
commented
Aug 16, 2023
Comment on lines
+36
to
+37
| mean(predict(x, newdata = head(mtcars), type = "ppd")), | ||
| mean(predict(res, newdata = head(mtcars), type = "ppd")), |
There was a problem hiding this comment.
Testing the mean because these predictions involve randomness.
juliasilge
commented
Aug 16, 2023
Comment on lines
+49
to
+50
| mean(predict(x, new_data = head(mtcars))$.pred), | ||
| mean(predict(res, new_data = head(mtcars))$.pred), |
There was a problem hiding this comment.
Same here:
library(parsnip)
## note that `bart()` has a pretty nasty namespace collision:
tidymodels::tidymodels_prefer()
spec <- bart(mode = "regression")
fitted <- fit(spec, mpg ~ ., mtcars)
predict(fitted, new_data = head(mtcars, n = 3))
#> # A tibble: 3 × 1
#> .pred
#> <dbl>
#> 1 20.8
#> 2 20.6
#> 3 24.4
predict(fitted, new_data = head(mtcars, n = 3))
#> # A tibble: 3 × 1
#> .pred
#> <dbl>
#> 1 20.8
#> 2 20.6
#> 3 24.6
predict(fitted, new_data = head(mtcars, n = 3))
#> # A tibble: 3 × 1
#> .pred
#> <dbl>
#> 1 20.7
#> 2 20.6
#> 3 24.6Created on 2023-08-16 with reprex v2.0.2
juliasilge
requested review from
simonpcouch and
topepo
and removed request for
simonpcouch
|
@topepo I just pinged you for a review because Simon is OOO and we need to do a butcher release ahead of the rsample release. Let me know if you aren't able to take a look in the very near future! |
24 tasks
topepo
reviewed
Aug 22, 2023
| res <- fit(spec, mpg ~ ., mtcars) | ||
| x <- butcher(res) | ||
|
|
||
| expect_equal( |
There was a problem hiding this comment.
I would add some tests with predict(type = "conf_int") and predict(type = "pred_int") too (just in case).
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262
Turns out we need that
sigmaslot for predicting withtype = "ppd"as well as for parsnip'bart().