[TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling. #9402

jquick-axway · 2017-09-05T21:32:18Z

JIRA: https://jira.appcelerator.org/browse/TIMOB-25086

Summary:

TextArea:
- Can now be scrolled vertically within a ScrollView, TableView, or ListView.
- Will scroll parent ScrollView when reaching top/bottom scroll bounds of TextArea. (All OS versions.)
- Will scroll parent TableView/ListView on Android 4.4 and above when reaching scroll bounds.
Vertical ScrollView:
- Can now be scrolled within another ScrollView, TableView, or ListView.
- Will scroll parent ScrollView when reaching top/bottom scroll bounds. (All OS versions.)
- Will scroll parent TableView/ListView on Android 4.4 and above when reaching scroll bounds.
Modified TextField/TextArea to use Google's "TextInputEditText" class:
- Resolves warning logged by the new "TextInputLayout" class Titanium using.
- Displays hint text in IME when in "extract" mode.

ScrollView Test:

Run TIMOB-25086 script ScrollViewTextAreasTest.js on Android.
Scroll one of the TextAreas fields up and down.
Verify that the TextArea scrolls.
Verify when scrolling up, ScrollView scrolls up when reaching bounds of the TextArea.
Verify when scrolling down, ScrollView scrolls down when reaching bounds of the TextArea.
Do a long-press on one of the words in the TextArea.
Verify that the word gets highlighted.
Tap another TextArea.
Verify that the tapped TextArea is in edit mode.
Scroll the ScrollView itself by dragging the left side of the view.

TableView Test:

Run TIMOB-25086 script TableOfTextAreasTest.js on Android 5.0 or higher.
Scroll one of the TextAreas fields up and down.
Verify that the TextArea scrolls.
Verify when scrolling up, TableView scrolls up when reaching bounds of the TextArea. (Only supported on Android 4.4 and higher.)
Verify when scrolling down, TableView scrolls down when reaching bounds of the TextArea. (Only supported on Android 4.4 and higher.)
Do a long-press on one of the words in the TextArea.
Verify that the word gets highlighted.
Tap another TextArea.
Verify that the tapped TextArea is in edit mode.
Scroll the TableView itself by dragging the left side of the view.
Run steps 2-10 above on an Android 4.4 device.
Run steps 2-10 above on an Android 4.1 device. (Note steps 4 and 5 where TableView cannot be scrolled when scrolling TextArea. This is normal.)

Deeply Nested Scrolling Test:

Run TIMOB-25086 script ScrollViewNestingTest.js on Android.
Verify that WebViews cannot be scrolled.
Verify that the TextArea can be scrolled vertically.
Verify that the inner/nested vertical ScrollView can be scrolled.
Verify that the horizontal ScrollView can be scrolled.
Verify that the TableView can be scrolled. (This is only supported on Android 5.0 and higher.)
Verify that the ListView can be scrolled. (This is only supported on Android 5.0 and higher.)
Tap the floating blue "Disable canCancelEvents" button in the bottom right corner. (Window's main ScrollView cannot be scrolled in this mode except via a scrollable child view.)
Verify that the ListView can be scrolled. (Works on all Android OS version.)
Verify that the TableView can be scrolled. (Works on all Android OS version.)
Verify that the horizontal ScrollView can be scrolled.
Verify that the inner/nested vertical ScrollView can be scrolled.
Verify that the WebViews can be scrolled.

…e scrollable within another scrollable view. - Created new TiListView class: * New class used by Titanium ListView and TableView. * Needed to support nested scrolling child views on OS versions older than Android 5.0. * Moved TiListView "canScroll" property to this new class. (This means we can support "Ti.UI.TableView.scrollable" property in the future.)

garymathews · 2017-09-08T15:18:40Z

android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/TiNestedListView.java

+	private static class ApiLevel16
+	{
+		/** Constructor made private to prevent instances from being made. */
+		private ApiLevel16() {}


Minor, you can make this an abstract class to prevent instances from being made instead of creating a private constructor.

private static abstract class ApiLevel16

Same for the others

garymathews · 2017-09-08T15:25:33Z

android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/TiNestedListView.java

+		 * @param listView The list view to be scrolled. Can be null, in which case this method will no-op.
+		 * @param y The y-axis distance in pixels to scroll the list view by.
+		 */
+		public static void scrollListBy(ListView listView, int y)


I'm not sure of the benefit of this since there are a lot of dalvikvm reference warnings from the support libraries themselves. But since it's here, why not?

garymathews

CR: minor, see above
FT: PASS

Awesome!! 🎉

mukherjee2

Tested with this environment:
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.4-master.9
Appc CLI NPM: 4.2.9
Titanium SDK version: 7.0.0.v20170907111553
Appcelerator Studio, build: 4.9.1.201707200100
Android OS 4.1, 4.4, 7.1

I tested with the above Android OS versions as specified in the test cases. The three test cases that Josh wrote in this PR were used to validate the fix. All passed.

jquick-axway added 2 commits September 5, 2017 13:14

Merge branch 'master' into TIMOB-25086

c5e0142

jquick-axway added android improvement parity 👯‍♀️ labels Sep 5, 2017

jquick-axway added this to the 7.0.0 milestone Sep 5, 2017

jquick-axway requested a review from garymathews September 5, 2017 21:32

jquick-axway and others added 2 commits September 5, 2017 14:39

Android: Removed unused Java imports due to [TIMOB-25086] changes.

8d71e40

Merge branch 'master' into TIMOB-25086

16be1b2

jquick-axway mentioned this pull request Sep 7, 2017

[TIMOB-24639] Android: Refactor TextInputLayout implementation #9361

Merged

Merge branch 'master' into TIMOB-25086

3b92805

garymathews reviewed Sep 8, 2017

View reviewed changes

garymathews suggested changes Sep 8, 2017

View reviewed changes

Merge branch 'master' into TIMOB-25086

49d199c

mukherjee2 requested review from garymathews and mukherjee2 September 8, 2017 15:55

mukherjee2 approved these changes Sep 8, 2017

View reviewed changes

Merge branch 'master' into TIMOB-25086

b3e06b1

mukherjee2 merged commit 2afcee4 into tidev:master Sep 8, 2017

mukherjee2 mentioned this pull request Sep 8, 2017

Revert "[TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling." #9418

Merged

garymathews mentioned this pull request Sep 14, 2017

[6_2_X][TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling #9433

Merged

This was referenced Sep 29, 2017

[TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling #9490

Merged

[6_3_X][TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling #9491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling. #9402

[TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling. #9402

jquick-axway commented Sep 5, 2017

garymathews Sep 8, 2017 •

edited

Loading

garymathews Sep 8, 2017

garymathews left a comment

mukherjee2 left a comment

[TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling. #9402

[TIMOB-25086] Android: Modified TextArea and vertical ScrollView to support nested scrolling. #9402

Conversation

jquick-axway commented Sep 5, 2017

garymathews Sep 8, 2017 • edited Loading

Choose a reason for hiding this comment

garymathews Sep 8, 2017

Choose a reason for hiding this comment

garymathews left a comment

Choose a reason for hiding this comment

mukherjee2 left a comment

Choose a reason for hiding this comment

garymathews Sep 8, 2017 •

edited

Loading