Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modernize Apple Script to open Xcode #13898

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Aug 16, 2023

The Apple Script wasn't touched for forever, so I added some improvements:

  • Support the new macOS system settings app that has different pane identifiers (this was broken)
  • Clean up the dialog and split the large message into title and message to look more native
  • Use the new macOS wordings for "System Settings" (new) vs "System Preferences" (old), etc.

Note: Github cannot properly display the diff as it's in binary form. Using the Apple Script app (built-in), the code can be observed.

Before:

After:

@cb1kenobi
Copy link
Contributor

I don't have access to a mac right now. @m1ga can you test this? I think this script is invoked when you package an iOS app for the App Store and it opens the organizer in Xcode after the build.

@m1ga
Copy link
Contributor

m1ga commented Aug 16, 2023

@cb1kenobi I can test it later 👍

@m1ga
Copy link
Contributor

m1ga commented Aug 16, 2023

  • I've tested it without the permission so I can see the new dialog:
    Screenshot_20230816_201953
  • button opens the system settings
  • if I enable it and build again it will open Xcode

Tested it on 12.6.7 (Monterey), Xcode 14.2

Is there anything else I need to test? It builds the app and opens XCdoe so it looks fine.

@cb1kenobi I'm running https://github.com/kholia/OSX-KVM on Linux 😉 Think that will run on Windows too

@hansemannn hansemannn merged commit 0f82b8f into tidev:master Aug 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants