fix(ios): enable webview inspection #13879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
reviewed
Jul 6, 2023
|
tested with 16.4 simulator works fine but it doesn't use the version code check so it will still crash on 15.5 🤔 |
hansemannn
requested changes
Jul 10, 2023
hansemannn
approved these changes
Jul 10, 2023
|
Just saw that the other PR is using That works now. 15.5 and 16.4 simulators are now working |
|
If possible, please still add the |
…titanium_mobile into 230704_ios_webview
|
ah I see! I've added the #if.. part again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to this PR: #13812
This one only enabled inspection for the JSContext and not the the webview itself.
https://webkit.org/blog/13936/enabling-the-inspection-of-web-content-in-apps/
has two parts for that.
Slack thread: https://tidev.slack.com/archives/C03CVQX2A/p1688465009923559