fix(ios): fix console.log formatting crash on non Apple Silicon devices #13834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same error as before. Just is now |
|
Weird. Then I am not able to fix it right now, since I don't have any device to test with either :/ |
|
Tested SDK 12.2.0.v20230511080743 on Mac Intel but still doesn't work. |
|
any way we can help to get this fixed? |
|
If someone can get me a non-Apple-Silicon device, I'd love to. Right now, it's super hard to debug without it. |
|
We can organize a remote desktop session |
|
sadly I only have one and need it 😄 |
hansemannn
force-pushed
the
fix/ios-formatting
branch
from
fa4a67b
to
62b0076
Compare
hansemannn
changed the title
|
@m1ga I just pushed the updated fix that could work. Let me know if it works already! |
|
@hansemannn works fine for me! Well done! |
|
Nice! 🚀 @ottopic Can you confirm as well? That was really the longest time I've spent, yet to figure out the 3 lines of code 🥲 |
|
Yes it works! Thank you @hansemannn |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not reproduce the initial crash on my device, but this change could fix #13738