Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly expose precompile flags for Ti.Media.queryMusicLibrary API #13398

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

hansemannn
Copy link
Collaborator

Fixes #13396

@m1ga
Copy link
Contributor

m1ga commented Apr 16, 2022

will show this error

[TRACE] In file included from /Users/miga/Documents/titanium/test_test/build/iphone/Classes/MediaModule.m:11:
[TRACE] /Users/miga/Documents/titanium/test_test/build/iphone/Classes/MediaModule.h:56:3: error: unknown type name 'MPMediaPickerController'; did you mean 'UIImagePickerController'?
[TRACE]   MPMediaPickerController *musicPicker;
[TRACE]   ^~~~~~~~~~~~~~~~~~~~~~~
[TRACE]   UIImagePickerController
[TRACE] In module 'UIKit' imported from /Users/miga/Documents/titanium/test_test/build/iphone/test_test_Prefix.pch:7:
[TRACE] /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS15.4.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIImagePickerController.h:69:12: note: 'UIImagePickerController' declared here
[TRACE] @interface UIImagePickerController : UINavigationController <NSCoding>
[TRACE]            ^
[TRACE] 1 error generated.

@hansemannn
Copy link
Collaborator Author

Sorry, missed one import check! Pre-compile statements are super stressful, but they are an important feature to prevent app rejections (because things like camera API's require the NSCameraUsageDescription). I hope it's fine now!

@m1ga
Copy link
Contributor

m1ga commented Apr 17, 2022

Builds fine now. I'll close mine in favor of this one

@hansemannn hansemannn merged commit 74a6e3c into tidev:master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: MediaModule use of undeclared identifier
2 participants