You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle separatorStyle: Ti.UI.TABLE_VIEW_SEPARATOR_STYLE_NONE on API < 23 (separator souldn't be visible)
handle separatorStyle: Ti.UI.TABLE_VIEW_SEPARATOR_STYLE_SINGLE_LINE with non zero separatorHeight and no separatorColor on Android API 21 (height should be applied) Put warning into docs, advise to set separatorColor on API < 23
🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Warnings
⚠️
There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖
✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖
✅ All tests are passing
Nice one! All 19694 tests are passing.
(There are 1157 skipped tests not included in that total)
📖
🎉 Another contribution from our awesome community member, drauggres! Thanks again for helping us make Titanium SDK better. 👍
@drauggres Thanks for this! It looks quite severe, so I think it should be prioritized. Apart form this PR, is there any workaround for the crash, e.g. setting the separator color?
@drauggres Thanks for this! It looks quite severe, so I think it should be prioritized. Apart form this PR, is there any workaround for the crash, e.g. setting the separator color?
Yes, you need to always specify a separatorColor (even with separatorStyle: Ti.UI.TABLE_VIEW_SEPARATOR_STYLE_NONE) to force a non-default separator, which will prevent the exception
The reason will be displayed to describe this comment to others. Learn more.
Tested and working great here! I would wait for @m1ga for another review and then this can be merged! @drauggres Please also rebase this one (if possible, all your open PR's - they are very close to be merged :))
Please also rebase this one (if possible, all your open PR's - they are very close to be merged :))
Done.
I think this option was enabled in the appcelerator repo, but it is disabled now.
It adds the Update branch button, so maintainers and author can quickly merge master into PR source branch.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default
listDivideron API < 23 is instance ofNinePatchDrawable, not aGradientDrawable.fix #13261
separatorStyle: Ti.UI.TABLE_VIEW_SEPARATOR_STYLE_NONEon API < 23 (separator souldn't be visible)handlePut warning into docs, advise to setseparatorStyle: Ti.UI.TABLE_VIEW_SEPARATOR_STYLE_SINGLE_LINEwith non zeroseparatorHeightand noseparatorColoron Android API 21 (height should be applied)separatorColoron API < 23