Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add defaultCalendar to Ti.Calendar #13219

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Dec 20, 2021

Fixes #13218

Adds Ti.Calendar.defaultCalendar parity

example

if (!Ti.Calendar.hasCalendarPermissions()) {
	Ti.Calendar.requestCalendarPermissions(function(e) {
		if (e.success) {
			console.log(Ti.Calendar.defaultCalendar);
		}
	});
} else {
	console.log(Ti.Calendar.defaultCalendar);
}

make sure to add this to tiapp.xml

<uses-permission android:name="android.permission.READ_CALENDAR"/>
<uses-permission android:name="android.permission.WRITE_CALENDAR"/>

@build
Copy link
Contributor

build commented Dec 20, 2021

Fails
🚫 Test reports missing for MacOS. This indicates that a build failed or the test app crashed
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 16367 tests are passing.
(There are 900 skipped tests not included in that total)

📖 🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍

Generated by 🚫 dangerJS against 1a845ee

@hansemannn hansemannn merged commit 0d20ec0 into tidev:master Apr 12, 2022
@m1ga m1ga deleted the defaultCalendar branch April 12, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: add defaultCalendar to Ti.Calendar
3 participants