-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): menu and toolbar icons to use ActionBar style colors #13147
Conversation
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
FT: PASS
I wonder if this change caused the <Alloy>
<Window>
<Menu platform="android">
<MenuItem title="Test" />
</Menu>
</Window>
</Alloy> cc @m1ga, you may have seen the error log as well. EDIT: It seems like the issue is a missing |
I'll check that 👍 |
@hansemannn it's strange. I can't reproduce it at the moment with 10.2.0. Neither with the demo code nor with my app 🤔 I had this for a long time but now I don't see it anymore. I'll give it another try later today |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28547
Summary:
When setting menu/toolbar icons to a resource ID (ie: a vector drawable), the icon should use the theme/style assigned to the ActionBar or Toolbar. Currently, it uses the style colors assigned to the activity window, which won't be the same as the ActionBar if using a DarkActionBar theme.
Test: