Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): selectedBackgroundGradient deprecation shown when not using it #13092

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

nicolomonili
Copy link
Contributor

@nicolomonili nicolomonili commented Sep 29, 2021

@build
Copy link
Contributor

build commented Sep 29, 2021

Warnings
⚠️ Tests have failed, see below for more information.
⚠️

Commit 09e970d09d822e74e0f66b0a704c9b741ce222f8 has a message "Update TiUITableViewRowProxy.m to fix warning

fix for #12969" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖 ❌ 11 tests have failed There are 11 tests failing and 1162 skipped out of 20653 total tests.
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖 🎉 Another contribution from our awesome community member, nicolomonili! Thanks again for helping us make Titanium SDK better. 👍
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.5.0.Titanium.Geolocation.methods#reverseGeocoder() works via Promise return value (5.0.2)2.115
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.5.0.Titanium.Geolocation.methods#reverseGeocoder() works via function callback (5.0.2)5.01
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:645:32)
android.emulator.5.0.Titanium.Geolocation.methods#forwardGeocoder() works via Promise return value (5.0.2)5.041
Error: done() invoked with non-Error: {"source":{"accuracy":1,"locationServicesEnabled":true,"hasCompass":true,"lastGeolocation":"{\"latitude\":37.4219983,\"longitude\":-122.084,\"altitude\":5,\"accuracy\":20,\"heading\":0,\"speed\":0,\"timestamp\":1633458831000}","apiName":"Ti.Geolocation","bubbleParent":true,"__propertiesDefined__":true},"code":-1,"success":false}
at /ti.geolocation.test.js:610:12
android.emulator.5.0.Titanium.Geolocation.methods#forwardGeocoder() works via callback argument (5.0.2)5.019
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:585:32)
android.emulator.5.0.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.447
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.5.0.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.438
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.5.0.Titanium.UI.WebViewbasic authentication should work properly (5.0.2)30.018
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.main.Titanium.Geolocation.methods#forwardGeocoder() works via callback argument (12)5.011
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:585:32)
android.emulator.main.Titanium.UI.WebViewbasic authentication should work properly (12)30.005
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.WebViewbasic authentication should work properly (15.0.0)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.UI.WebViewbasic authentication should work properly (11.5.2)30.008
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against bcf8e35

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ewanharris
Copy link
Collaborator

@nicolomonili, could you please sign the CLA

@lokeshchdhry
Copy link
Contributor

FR Passed.

@ewanharris ewanharris changed the title Update TiUITableViewRowProxy.m to fix warning fix(ios): selectedBackgroundGradient deprecation shown when not using it Oct 6, 2021
@ewanharris ewanharris merged commit 93f5689 into tidev:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants