refactor(android): optimize ImageView image download peformance #13078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TIMOB-28538
Tests:
|
garymathews
reviewed
Sep 22, 2021
There was a problem hiding this comment.
Although unrelated to your changes, I'm seeing that TiDrawableReference is retrying a bad image URL up to seven times. There's old code that does this due to a bug from Android 2.3 😱
We should change DEFAULT_DECODE_RETRIES to 2, amend this for to:
for (int i = 1; i < decodeRetries; i++) {and increase this timeout to 1000ms or 3000ms
android/titanium/src/java/org/appcelerator/titanium/util/TiLoadImageManager.java
Outdated
Show resolved
Hide resolved
garymathews
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
CR: PASS
FT: PASS
Here's a modified ListViewImageRemoteNoCacheTest.js test so you can verify the images that are loaded are not the same.
const imageUrls = [
'https://github.com/appcelerator/titanium_mobile/raw/master/tests/Resources/ExifFlipHorizontal.jpg',
'https://github.com/appcelerator/titanium_mobile/raw/master/tests/Resources/ExifFlipVertical.jpg',
'https://github.com/appcelerator/titanium_mobile/raw/master/tests/Resources/ExifRotate180.jpg',
'https://github.com/appcelerator/titanium_mobile/raw/master/tests/Resources/ExifRotate270.jpg',
'https://github.com/appcelerator/titanium_mobile/raw/master/tests/Resources/ExifRotate90.jpg',
'https://github.com/appcelerator/titanium_mobile/raw/master/tests/Resources/ExifTranspose.jpg',
'https://github.com/appcelerator/titanium_mobile/raw/master/tests/Resources/ExifTransverse.jpg',
];
function createListViewSectionItems() {
const items = [];
for (let index = 1; index <= 1000; index++) {
const url = imageUrls[index % imageUrls.length];
items.push({ properties: {
title: `Row ${index}: ${url.split('/')[9]}`,
image: url
}});
}
return items;
}
const window = Ti.UI.createWindow();
window.add(
Ti.UI.createListView({
templates: {
template: {
properties: { layout: 'vertical' },
childTemplates: [
{
type: 'Ti.UI.ImageView',
bindId: 'image',
properties: { width: 160 }
},
{
type: 'Ti.UI.Label',
bindId: 'title',
properties: {
color: 'black',
font: { fontSize: '20dp', fontWeight:'bold' }
}
}
]
}
},
defaultItemTemplate: 'template',
sections: [
Ti.UI.createListSection({
headerTitle: 'ListView',
items: createListViewSectionItems(),
})
],
})
);
window.open();Also verified error event still triggers, as this test was failing on Jenkins.
const win = Ti.UI.createWindow();
const img = Ti.UI.createImageView();
img.addEventListener('error', e => {
alert(`Error loading image:\n\n${e.image}`);
});
img.image = 'https://invalid.host.com/image.jpg';
win.add(img);
win.open();
|
FR Passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
Summary:
ImageViewimage url download performance when:No-Cache.TiDrawableReference.Keyclass which guarantees uniqueness.TiImageLruCacheand replaced withTiImageCache.TiDownloadManager,TiLoadImageManager,TiFileHelper, andTiBlobLruCache.TiDownloadManageron startup if there were several ImageViews on screen. Can cause performance initial performance issues since thread pool size would be ignored.ImageView"decodeRetries" property default from5to2.ListView Complex Template Test:
ListViewTemplateComplexTest.jsattached to TIMOB-28538 on Android.ListView No-Cache Test:
ListViewImageRemoteNoCacheTest.jsattached to TIMOB-28538 on Android.Image Hash Code Collision Test:
FP.jpgandG1.jpgattached to TIMOB-18786 to project's./assets/imagesfolder.ImageHashTest.jsattached to TIMOB-18786 as your "app.js".