Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): allow apps with non-arm64 modules to be built on Apple Silicon #13029

Merged
merged 8 commits into from
Sep 6, 2021

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-28525

This pull request basically just replaces the way the process architecture is detected. It also improves the error message for non-arm64 modules to make it easier to resolve them one after another.

@build build added this to the 10.1.0 milestone Aug 17, 2021
@build
Copy link
Contributor

build commented Aug 17, 2021

Warnings
⚠️ Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 10 tests have failed There are 10 tests failing and 1162 skipped out of 20593 total tests.
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.5.0.Titanium.UI.WebViewblockedURLs (5.0.2)30.004
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.5.0.Titanium.UI.WebViewblacklistedURLs (5.0.2)30.005
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.main.Titanium.UI.WebViewblockedURLs (11)30.003
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.main.Titanium.UI.WebViewblacklistedURLs (11)30.009
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.WebView#findString() #findString with configuration (14.4.0)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.WebView#findString() #findString without configuration (14.4.0)29.999
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.WebViewblockedURLs (14.4.0)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.WebViewblacklistedURLs (14.4.0)30.001
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.UI.WebViewblockedURLs (11.4.0)30.124
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.UI.WebViewblacklistedURLs (11.4.0)30.008
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against a1e26f6

iphone/cli/commands/_build.js Outdated Show resolved Hide resolved
@hansemannn
Copy link
Collaborator Author

@ewanharris Cool?

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (although I don't have a shiny Apple Silicon device so can't FR)

@jquick-axway jquick-axway changed the title fix: allow apps with non-arm64 modules to be built on Apple Silicon fix(ios): allow apps with non-arm64 modules to be built on Apple Silicon Aug 19, 2021
@hansemannn
Copy link
Collaborator Author

May make sense to combine with #13032, but I can also rebase the other one ones this is merged

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR pass (confirmed with Hans that this works on an Apple Silicon mac)

@ewanharris ewanharris merged commit 3559744 into tidev:master Sep 6, 2021
@hansemannn hansemannn deleted the TIMOB-28525 branch September 6, 2021 12:27
@jasonkneen
Copy link
Contributor

Is this now in 10.1.0?

@ewanharris
Copy link
Collaborator

@jasonkneen, yes this shipped in 10.1.0

@jasonkneen
Copy link
Contributor

jasonkneen commented Nov 12, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants