-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): allow apps with non-arm64 modules to be built on Apple Silicon #13029
Conversation
Tests:
|
@ewanharris Cool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (although I don't have a shiny Apple Silicon device so can't FR)
May make sense to combine with #13032, but I can also rebase the other one ones this is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR pass (confirmed with Hans that this works on an Apple Silicon mac)
Is this now in 10.1.0? |
@jasonkneen, yes this shipped in 10.1.0 |
Awesome. Thanks.
… On Friday, Nov 12, 2021 at 09:54, Ewan Harris ***@***.*** ***@***.***)> wrote:
@jasonkneen (https://github.com/jasonkneen), yes this shipped in 10.1.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#13029 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAD2R4QICCJPCLOVIJFONTLULTP6BANCNFSM5CJNNPAA).
|
JIRA: https://jira.appcelerator.org/browse/TIMOB-28525
This pull request basically just replaces the way the process architecture is detected. It also improves the error message for non-arm64 modules to make it easier to resolve them one after another.