fix(ios): amend TiMediaVideoPlayer parent controller

[garymathews]

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28518

Summary:

• Amend changes from fix(iOS): set parent view controller for detached view controllers #12233
• Note that showing a video fullscreen may log a warning. We're reverting the change that fixed that since it had other negative repercussions.

---

Framed Video Test:

1. Build and run the below on iOS.
2. Verify a small video is shown within a blue frame.
3. Tap on the video and select the "fullscreen" button.
4. Verify the video is now shown fullscreen.

const window = Ti.UI.createWindow();
const videoView = Ti.Media.createVideoPlayer({
	url: "https://raw.githubusercontent.com/appcelerator/titanium_mobile/master/tests/remote/mov_bbb.mp4",
	autoplay: true,
	borderWidth: "4dp",
	borderColor: "blue",
	width: "300dp",
	height: "200dp",
});
window.add(videoView);
window.open();

---

NavigationWindow Test:

1. Build and run the below on iOS.
2. Tap on the "Play Video" button.
3. Verify a child window slides in and shows a video.
4. Tap on the video and select the "fullscreen" button.
5. Verify the video is now shown fullscreen and you can't see the top navigation bar anymore.

let navigationWindow = null;
const parentWindow = Ti.UI.createWindow({
	title: "Parent Window",
	backgroundColor: OS_IOS ? "white" : "?android:attr/colorBackground",
});
const openButton = Ti.UI.createButton({ title: "Play Video" });
openButton.addEventListener("click", () => {
	const childWindow = Ti.UI.createWindow({ backgroundColor: "black" });
	childWindow.add(Ti.Media.createVideoPlayer({
		url: "https://raw.githubusercontent.com/appcelerator/titanium_mobile/master/tests/remote/mov_bbb.mp4",
		autoplay: true,
		width: Ti.UI.FILL,
		height: Ti.UI.FILL,
	}));
	navigationWindow.openWindow(childWindow, { animated: true });
});
parentWindow.add(openButton);
navigationWindow = Ti.UI.createNavigationWindow({
	window: parentWindow,
});
navigationWindow.open();

---

TabGroup Test:

1. Build and run the below on iOS.
2. Verify 1st tab shows a small video view within a blue border.
3. Tap on the video and verify it plays.
4. Tap on the video and select the fullscreen option.
5. Tap on the video and exit fullscreen mode.
6. Select tab 2 and repeat steps 2-5.

function createTab(title, icon, videoUrl) {
	const window = Ti.UI.createWindow({ title: title });
	window.add(Ti.Media.createVideoPlayer({
		url: videoUrl,
		autoplay: false,
		borderWidth: "4dp",
		borderColor: "blue",
		width: "300dp",
		height: "200dp",
	}));
	const tab = Ti.UI.createTab({
		title: title,
		icon: icon,
		window: window,
	});
	return tab;
}

const tabGroup = Ti.UI.createTabGroup({
	tabs: [
		createTab("Tab 1", "/assets/images/tab1.png", "https://raw.githubusercontent.com/appcelerator/titanium_mobile/master/tests/remote/mov_bbb.mp4"),
		createTab("Tab 2", "/assets/images/tab2.png", "https://github.com/appcelerator/kitchensink-v2/raw/master/app/assets/videos/example-video.mp4"),
	],
});
tabGroup.open();

[build]

	Fails
🚫	Tests have failed, see below for more information.

	Messages
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	❌ 1 tests have failed There are 1 tests failing and 960 skipped out of 15528 total tests.
📖	👍 Hey!, You deleted more code than you added. That's awesome!

Tests:

Classname	Name	Time	Error
test.handleBuild	works	2.309	Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-13011/build/lib/test/test-test.js)

Generated by 🚫 dangerJS against e244779

[jquick-axway]

FR: Failed

When showing the video player not-fullscreen, the video is wrongly displayed in the window's top-left corner instead.

You can reproduce the issue with the below. The video should be played within a 300x200 view in the center of the window (it has a blue border), but the video is wrongly shown in the top-left corner.

const window = Ti.UI.createWindow();
const videoView = Ti.Media.createVideoPlayer({
	url: "https://raw.githubusercontent.com/appcelerator/titanium_mobile/master/tests/remote/mov_bbb.mp4",
	autoplay: true,
	borderWidth: "4dp",
	borderColor: "blue",
	width: "300dp",
	height: "200dp",
});
window.add(videoView);
window.open();

[jquick-axway]

CR/FR: Pass

[ewanharris]

FR Pass. Original behaviour is restored, tests cases and sample from ticket all now function as expected.