-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): improve pre-loading optimization of ListView and TableView #12781
Conversation
Tests:
|
@m1ga I believe you ran into an issue where images would sometimes not load? Let me know if this solves that issue for you |
@garymathews I'll try this PR, sounds great! For me the issue with the "not loading images" was already fixed in the master builds after March 12th but I've linked it in the other issue I had because there was someone else where the master build wasn't working. So perhaps that issues is fixed for him too |
6403c9c
to
275afac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
@garymathews , With the fix I see an increase in the time from splash to showing the window of 3 - 4 seconds as compared to 2 seconds without. Is this expected ? |
FR Passed. |
TEST CASE 1
TEST CASE 2
JIRA Ticket