Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 10_0_X] refactor(android): use material widgets/styles and default to DayNight theme #12523

Merged
merged 30 commits into from
Mar 5, 2021

Conversation

build
Copy link
Contributor

@build build commented Mar 5, 2021

Backport of #12353.
See that PR for full details.

} else {
// await exec(`adb -e shell "run-as ${APP_ID} cat '${filepath}'" > ${dest}`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ build/lib/test/test.js line 885 – Missing JSDoc parameter description for 'testResults'. (valid-jsdoc)

@build
Copy link
Contributor Author

build commented Mar 5, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️

Commit 3266bf74c545edc759acc83a547045e4cfa05a20 has a message "doc(ios): deprecate Ti.UI.iOS.SystemButtonStyle" giving 1 errors:

  • type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]
⚠️

Commit 00c29bbe6731eecfdfdb9c6026d809cdcf1c70f8 has a message "feat(macOS): add checkbox style to Ti.UI.Switch

Fixes TIMOB-28302" giving 1 errors:

  • scope must be lower-case
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
⚠️

build/lib/test/test.js#L488 - build/lib/test/test.js line 488 – 'stripped' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖 ❌ 4 tests have failed There are 4 tests failing and 951 skipped out of 15137 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.NavigationWindowbasic open/close navigation (5.0.2)10.06
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.Window"after each" hook for "window_close_order_2" (5.0.2)6.714
Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)12.905
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.Media.properties.audioPlaying is a Boolean (10.15.4)39.751
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
run@file:///ti.main.js:8718:22
processImmediateQueue@file:///ti.main.js:8781:18
drainQueues@file:///ti.main.js:8758:52

Generated by 🚫 dangerJS against e2fb4f8

@hansemannn
Copy link
Collaborator

@sgtcoolguy Thanks for handling this! I just tried to fetch the latest 10_0_X build, but it seems like the branch is not registered to be installed so far with ti sdk install -b 10_0_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants