Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 9_3_X] fix(android): handle encoded WebView url #12463

Merged
merged 6 commits into from
Feb 10, 2021
Merged

[Backport 9_3_X] fix(android): handle encoded WebView url #12463

merged 6 commits into from
Feb 10, 2021

Conversation

build
Copy link
Contributor

@build build commented Feb 10, 2021

Backport of #12450.
See that PR for full details.

@build build added this to the 9.3.2 milestone Feb 10, 2021
@build build requested a review from a team February 10, 2021 17:28
@build
Copy link
Contributor Author

build commented Feb 10, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 7 tests have failed There are 7 tests failing and 900 skipped out of 13171 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.Clipboard.examplesCopy Text to the Clipboard (11)0.009
Error: Attempt to invoke interface method 'java.lang.String java.lang.CharSequence.toString()' on a null object reference
at Context.<anonymous> (/ti.ui.clipboard.test.js:131:24)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
      at Titanium.timeslice (/ti-mocha.js:5764:23)
android.emulator.Titanium.UI.WebViewblacklistedURLs (11)36.117
Error: timeout of 30000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
ios.ipad.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)0.917
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped@2x~ipad.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:5764:29
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.327
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E5921EF5-BABB-4F63-B755-026BEBF32F3D/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)1.481
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.433
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/98B8AA72-8123-4ECA-9CE5-BB0E582906A6/mocha.app/ti-mocha.js:5764:29
ios.macos.Titanium.UI.Semantic Colorsuse semantic colors via color properties (10.15.5)0.088
Error: expected 'Ti.UI.View' to match image ('snapshots/systemredcolor_light.png')
    expected 12 to be 6
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12463/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12463/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12463/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.test.js:363:34

Generated by 🚫 dangerJS against ca6240d

@sgtcoolguy sgtcoolguy merged commit f5f8f67 into tidev:9_3_X Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@build @sgtcoolguy @garymathews