fix(tests): move to getter/setter #12441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like iOS is missing some getter/setters |
|
Relates to #12310 |
|
@m1ga Are you fine to merge this one? The tests seem to pass, so the docs are not broken. |
|
@hansemannn yes, should still be fine here to merge. won't affect builds at the moment since the tests won't run automatically. |
m1ga
added a commit
to m1ga/titanium_mobile
that referenced
this pull request
Mar 26, 2022
This reverts commit 734c41b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/[TICKET]
Optional Description:
Using getter/setter instead of methods to avoid deprecation warnings.