Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): calculate proper row width for UITableViewStyleInsetGrouped #12439

Merged
merged 5 commits into from
Feb 4, 2021
Merged

fix(ios): calculate proper row width for UITableViewStyleInsetGrouped #12439

merged 5 commits into from
Feb 4, 2021

Conversation

build
Copy link
Contributor

@build build commented Feb 4, 2021

Backport of #12419.
See that PR for full details.

@build build added this to the 9.3.2 milestone Feb 4, 2021
@build build requested review from a team February 4, 2021 12:36
@build
Copy link
Contributor Author

build commented Feb 4, 2021 •
edited
Loading

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 4 tests have failed There are 4 tests failing and 812 skipped out of 12277 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.0)0.968
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:5764:29
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.0)0.337
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/083EB293-6DD6-4119-A4D5-72351034E69F/data/Containers/Bundle/Application/94E475B7-866E-46FA-8D76-B182C17363E5/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.0)1.06
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.0)0.441
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/4ACD0E81-1799-4B5B-AE3B-ABA3D11B297E/data/Containers/Bundle/Application/4B03880D-E91F-435F-9776-BCF28FD0FD25/mocha.app/ti-mocha.js:5764:29

Generated by 🚫 dangerJS against 9ea1053

@ewanharris ewanharris changed the title [Backport 9_3_X] fix(ios): calculate proper row width for UITableViewStyleInsetGrouped fix(ios): calculate proper row width for UITableViewStyleInsetGrouped Feb 4, 2021
@ewanharris ewanharris merged commit a34e964 into tidev:9_3_X Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs in-qe-testing 🕵 ios
Projects
None yet
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@build @ewanharris @vijaysingh-axway