Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 9_3_X] fix(iOS): swift enabling in Objc module should build #12433

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

build
Copy link
Contributor

@build build commented Feb 2, 2021

Backport of #12372.
See that PR for full details.

@build build added this to the 9.3.2 milestone Feb 2, 2021
@build
Copy link
Contributor Author

build commented Feb 2, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
⚠️

Commit 5a865712f6bce7b295322c7e06e5ef9ae3eaf174 has a message "fix(iOS): swift enabling in Objc module should build" giving 1 errors:

  • scope must be lower-case
⚠️

iphone/cli/commands/_buildModule.js#L157 - iphone/cli/commands/_buildModule.js line 157 – Avoid calling back inside of a promise. (promise/no-callback-in-promise)

⚠️

iphone/cli/commands/_buildModule.js#L157 - iphone/cli/commands/_buildModule.js line 157 – Expected catch() or return (promise/catch-or-return)

Messages
📖

💾 Here's the generated SDK zipfile.

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖 ❌ 4 tests have failed There are 4 tests failing and 994 skipped out of 15831 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.WebViewuserAgent (11)60.007
Error: timeout of 60000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
ios.ipad.Titanium.UI.WebViewuserAgent (14.2)59.999
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/8BE82169-FB42-427D-9BA5-0E32F1F90E36/data/Containers/Bundle/Application/13A4E6DD-5F53-4649-B656-9E8D8F2516BA/mocha.app/ti-mocha.js:4290:32
ios.iphone.Titanium.UI.WebViewuserAgent (14.0)60
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/B15C936C-AE26-45D6-BA6B-EC640E4DAA5A/data/Containers/Bundle/Application/93F23B8E-8860-4B89-8343-C3CEA03CF5BA/mocha.app/ti-mocha.js:4290:32
ios.macos.Titanium.UI.WebViewuserAgent (10.15.5)60.064
Error: timeout of 60000ms exceeded
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12433/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4290:32

Generated by 🚫 dangerJS against 5a86571

@sgtcoolguy sgtcoolguy merged commit 1d1f174 into tidev:9_3_X Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants