-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): fix default value of property pictureInPictureEnabled #12239
Conversation
|
@@ -576,6 +576,7 @@ properties: | |||
summary: The type of media in the player's current item first track. | |||
exclude-platforms: [android] | |||
type: String | |||
permission: read-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the related unit test should be modified to assert the property is read-only
FR Passed. |
The backport to
Check the run for full details # Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 9_2_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12239-to-9_2_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/8c8600cea5c00246b4f41be4ce522ed460219ac1.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/6686addd651ffdfd31e04f5a8ba7742e1d85862f.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12239-to-9_2_X Then, create a pull request where the |
https://jira.appcelerator.org/browse/TIMOB-28221
This PR is to fix iOS related issue found in PR #12231 .