Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 9_2_X] fix(mac): generate missing macOS asset catalog icons #12211

Merged
merged 2 commits into from
Oct 24, 2020
Merged

[Backport 9_2_X] fix(mac): generate missing macOS asset catalog icons #12211

merged 2 commits into from
Oct 24, 2020

Conversation

build
Copy link
Contributor

@build build commented Oct 23, 2020

Backport of #12172.
See that PR for full details.

@build build added this to the 9.2.2 milestone Oct 23, 2020
@build
Copy link
Contributor Author

build commented Oct 23, 2020

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 733 skipped out of 8337 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.iOS.CollisionBehavior.exampleworks (14.0)15.002
Error: timeout of 15000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/AEB0AAF4-FED7-4BF5-8DDC-233DE4C6A1FF/data/Containers/Bundle/Application/DB29BB09-88B9-433C-828D-081806101DE9/mocha.app/ti-mocha.js:4326:27

Generated by 🚫 dangerJS against 083e7f7

@sgtcoolguy sgtcoolguy merged commit b242902 into tidev:9_2_X Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli 📟 community 🔥 improvement in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@build @sgtcoolguy @hansemannn