Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): update gradle tools and dependencies #12185

Merged
merged 5 commits into from
Oct 19, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Oct 16, 2020

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28173

Summary:

  • Updated gradle from 6.5.1 to 6.7
  • Updated Androd gradle tool from 4.0.1 to 4.1.0
    • Can no longer use Android Studio versions older than 4.1
  • Updated kotlin from 1.4.0 to 1.4.10
  • Updated AndroidX dependencies to newest versions
  • Removed remaining "ant" related files from Titanium SDK
  • Added ./build/scons-gradlew script
    • Changing linting tasks to use this new script.
    • Generates required local.properties file before running gradlew.

Note:
This change may cause the following NDK deprecation warning to be logged during the build. This involves us deprecating support for setting the NDK directory path in our CLI and only allows devs to set the NDK version instead. In the future, Google will require the NDK to be installed under the Android SDK's NDK side-by-side folder.

WARNING: NDK was located by using ndk.dir property. This method is deprecated and will be removed in a future release.

KitchenSink Test:

  1. Build and run kitchensink-v2 on Android.
  2. Navigate to every Ui window and verify that everything still works.

Hyperloop Test:

  1. Build and run hyperloop-example on Android.
  2. Navigate to every Ui window and verify that everything still works.

Module Test:

  1. Download the source for the ti.imagefactory module.
  2. Open the Terminal.
  3. CD to the ./ti.imagefactory/android folder.
  4. Enter: appc run -p android
  5. Verify that the module successfully builds and runs.

- Updated gradle from 6.5.1 to 6.7
- Updated Androd gradle tool from 4.0.1 to 4.1.0
  * Can no longer use Android Studio versions older than 4.1
- Updated kotlin from 1.4.0 to 1.4.10
- Updated AndroidX dependencies to newest versions
- Removed remaining "ant" related files from Titanium SDK

Fixes TIMOB-28173
@build
Copy link
Contributor

build commented Oct 16, 2020

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 12238 tests are passing.
(There are 1142 skipped tests not included in that total)

Generated by 🚫 dangerJS against 5c57238

@jquick-axway jquick-axway changed the title chore(android): update gradle tools and dependency chore(android): update gradle tools and dependencies Oct 16, 2020
- Guarantees "local.properties" file is alway generating when running lint.
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me!

@ssaddique
Copy link
Contributor

FR: Pass

Test Environment
SDK Ver: this PR
OS Ver: 10.15.6
Appc NPM: 5.0.0
Appc CLI: 8.1.1
Node Ver: 10.17.0
NPM Ver: 6.13.6
Java Ver: 1.8.0_162
Emulator: Pixel 4 (11.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants