Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): rely on event flush interval #12037

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Sep 11, 2020

  • Analytics events queue may not have time to flush after an exception occurs.
    • Rely on flush interval instead of forcing flush (may send events on next application launch)
TEST CASE
  • See JIRA

JIRA Ticket

@build
Copy link
Contributor

build commented Sep 11, 2020

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 7437 tests are passing.
(There are 711 skipped tests not included in that total)

Generated by 🚫 dangerJS against 48a2e41

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM.

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to see crash events being sent to dashboard.

Test case:

var win = Ti.UI.createWindow({
    backgroundColor: "white",
    layout: "vertical"
});

var flipBtn = Ti.UI.createButton({
    top: 50,
    title: "Flip"
});

var controlView = Ti.UI.createView({
});

var view1 = Ti.UI.createView({
    elevation: 20,
    width: 200,
    height: 200,
    top: 100,
    backgroundColor: "red"
});

controlView.add(view1);

var view2 = Ti.UI.createView({
    elevation: 20,
    width: 200,
    height: 200,
    top: 100,
    backgroundColor: "green"
});

win.add(flipBtn);
win.add(controlView);

var isShowGreen = false;

flipBtn.addEventListener('click', function () {
    if (isShowGreen) {
        isShowGreen = false;
        viewj1.show();
        controlView.animate({
            view: view1,
            transition: Ti.UI.iOS.AnimationStyle.FLIP_FROM_LEFT
        });
        view2.hide();
    } else {
        isShowGreen = true;
        view2.show();
        controlView.animate({
            view: view2,
            transition: Ti.UI.iOS.AnimationStyle.FLIP_FROM_LEFT
        });
        view1.hide();
    }
});

win.open();

Test Environment

MacOS Big Sur: 11.0 Beta 6
Xcode: 12.0 Beta 5
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.0-master.11""
iphone 8 Sim (14.0 Beta)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants