-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): rely on event flush interval #12037
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Able to see crash events being sent to dashboard.
Test case:
var win = Ti.UI.createWindow({
backgroundColor: "white",
layout: "vertical"
});
var flipBtn = Ti.UI.createButton({
top: 50,
title: "Flip"
});
var controlView = Ti.UI.createView({
});
var view1 = Ti.UI.createView({
elevation: 20,
width: 200,
height: 200,
top: 100,
backgroundColor: "red"
});
controlView.add(view1);
var view2 = Ti.UI.createView({
elevation: 20,
width: 200,
height: 200,
top: 100,
backgroundColor: "green"
});
win.add(flipBtn);
win.add(controlView);
var isShowGreen = false;
flipBtn.addEventListener('click', function () {
if (isShowGreen) {
isShowGreen = false;
viewj1.show();
controlView.animate({
view: view1,
transition: Ti.UI.iOS.AnimationStyle.FLIP_FROM_LEFT
});
view2.hide();
} else {
isShowGreen = true;
view2.show();
controlView.animate({
view: view2,
transition: Ti.UI.iOS.AnimationStyle.FLIP_FROM_LEFT
});
view1.hide();
}
});
win.open();
Test Environment
MacOS Big Sur: 11.0 Beta 6
Xcode: 12.0 Beta 5
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.0-master.11""
iphone 8 Sim (14.0 Beta)
TEST CASE
JIRA Ticket