Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): exclude arm64 architecture from simulator build #11844

Merged
merged 7 commits into from
Aug 6, 2020
Merged

fix(ios): exclude arm64 architecture from simulator build #11844

merged 7 commits into from
Aug 6, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.2.0 milestone Jul 24, 2020
@build
Copy link
Contributor

build commented Jul 24, 2020 •
edited
Loading

Warnings
⚠️

Commit efab8b3705fb8a4db3315b331c7e683e234ba0aa has a message "fix(ios): It xcode < 12 do not use EXCLUDED_ARCHS" giving 1 errors:

  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖

✅ All tests are passing
Nice one! All 2474 tests are passing.
(There are 235 skipped tests not included in that total)

Generated by 🚫 dangerJS against efab8b3

@vijaysingh-axway vijaysingh-axway changed the title fix(ios): remove arm64 architecture from simulator build fix(ios): exclude arm64 architecture from simulator build Aug 4, 2020
@sgtcoolguy sgtcoolguy merged commit 178bf92 into tidev:master Aug 6, 2020
sgtcoolguy pushed a commit that referenced this pull request Aug 6, 2020
@vijaysingh-axway @sgtcoolguy
fix(ios): exclude arm64 architecture from simulator build (#11844)
d092f25 
* fix(ios): itemclick event its firing instead of a move event when ordering items in a list iOS 13+
* fix(ios): remove arm64 architecture from simulator build
* If xcode < 12 do not use EXCLUDED_ARCHS

Fixes TIMOB-28042
sgtcoolguy added a commit to sgtcoolguy/titanium_mobile that referenced this pull request Aug 20, 2020
@sgtcoolguy
Revert "fix(ios): exclude arm64 architecture from simulator build (ti…
48b53a7 
…dev#11844)"

This reverts commit 178bf92.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

Assignees
No one assigned
Labels
ios
Projects
None yet
Milestone
9.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vijaysingh-axway @build @sgtcoolguy