Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): allow WebView to correctly handle query parameters #11762

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

ewanharris
Copy link
Collaborator

@ewanharris ewanharris changed the title Timob 27795 90 x fix(android): allow WebView to correctly handle query parameters Jun 8, 2020
@ssjsamir ssjsamir self-requested a review June 8, 2020 13:49
@build build added this to the 9.0.3 milestone Jun 8, 2020
@build build requested a review from a team June 8, 2020 14:11
@build
Copy link
Contributor

build commented Jun 8, 2020

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6575 tests are passing.
(There are 695 skipped tests not included in that total)

Generated by 🚫 dangerJS against b66c670

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed using the two test cases mentioned above. Able to see the query: ?data=1234alert and able to see the products section for when testing anchor tag support.
Test Environment

MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0","CLI":"8.0.0""
Andoird Pixl xl 7.1.1 Emulator 

@sgtcoolguy sgtcoolguy merged commit 5038295 into tidev:9_0_X Jun 8, 2020
@ewanharris ewanharris deleted the TIMOB-27795_90X branch August 31, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants