Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): navigationbar flicker issue #11703

Merged
merged 1 commit into from
May 18, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.0.2 milestone May 14, 2020
@build build requested a review from a team May 14, 2020 00:43
@build
Copy link
Contributor

build commented May 14, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6575 tests are passing.
(There are 696 skipped tests not included in that total)

Generated by 🚫 dangerJS against 792808a

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed: Navigation bar no longer flickers using the following test case

var win3 = Titanium.UI.createWindow({
backgroundColor: 'blue',
title: 'Next Blue',
largeTitleEnabled: true,
});
 
var win1 = Ti.UI.createWindow({
backgroundColor: 'blue',
title: 'Blue',
largeTitleEnabled: true,
});
var button = Titanium.UI.createButton({
title: 'Open Next Blue',
});
button.addEventListener('click', function(){
tabGroup.activeTab.open(win3);
});
 
win1.add(button);
 
var win2 = Ti.UI.createWindow({
backgroundColor: 'red',
title: 'Red',
largeTitleEnabled: true,
});
win2.add(Ti.UI.createLabel({text: 'I am a red window.'}));
 
var tab1 = Ti.UI.createTab({
window: win1,
title: 'Blue',
}),
tab2 = Ti.UI.createTab({
window: win2,
title: 'Red'
}),
tabGroup = Ti.UI.createTabGroup({
tabs: [tab1, tab2]
});
tabGroup.open();
 

Test Environment

MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
iphone 8 13.4 sim

@ssjsamir ssjsamir merged commit 71eabb2 into tidev:9_0_X May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants