-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): allow TiDownloadManager to fire fail listener #11575
Conversation
|
@garymathews Can you please turn that manual test into a mocha test? It looks like it should be pretty straightforward to convert... |
android/titanium/src/java/org/appcelerator/titanium/util/TiDownloadManager.java
Show resolved
Hide resolved
android/titanium/src/java/org/appcelerator/titanium/util/TiDownloadManager.java
Show resolved
Hide resolved
5b85187
to
3c8e3de
Compare
@jquick-axway Updated PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
@garymathews, using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR passed: Able to see the correct events being fired, tested with the test case above and the following test case:
Ti.UI.setBackgroundColor('#000');
var tabGroup = Ti.UI.createTabGroup();
var win1 = Ti.UI.createWindow({
title:'Tab 1',
backgroundColor:'#fff',
});
var img = Ti.UI.createImageView({
image:'http://files.daddyhunt.com/sites/default/files/imagecache/mangrid-212/photos/z/z/z/277606/Photo_on_2010-09-14_at_13.14_3.jpg'
});
win1.add(img);
img.addEventListener('error', function(){
Ti.API.info('--------------fired error event----------');
});
tabGroup.addTab(Ti.UI.createTab({
title:'Tab 1',
window:win1
}));
tabGroup.open();
Test Environment
MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel Xl 7.1.1 Sim
TiDownloadManager
to fire fail listener, which preventederror
events for some componentsTEST CASE
JIRA Ticket