-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): app/module builds fail with JDK 13 #11507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added "android.useAndroidX" gradle property which is now requried or else a build failure will occur. - Resolved Java and C/C++ build order issue with newest tool.
- Updated gradle wrapper/library to version 6.2.1. (Gradle added JDK 13 support in 6.0.0.)
jquick-axway
changed the title
fix(android): app/module builds fail with JDK 13 or higher
fix(android): app/module builds fail with JDK 13
Feb 29, 2020
|
- JDK 12 dropped support for Java 6 language support. Hyperloop now compiles with Java 8 language. - Updated hyperloop module version from 5.0.1 to 5.0.2.
garymathews
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
FR partially passed. Please see JIRA ticket for details |
FR: Pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
Summary:
New Build Warning:
App builds will now log the following deprecation warning. This is because gradle 6.0.0 has deprecated an API that Google's gradle build tool is currently using. We're stuck with this until Google resolves it their 4.0.0 build tool which hasn't been released yet.
Note to QE:
On Mac, you can have multiple JDKs installed. After installing JDK 13 and running the below tests, you can select the older installed JDK by doing the following at the command line.
List the JDK versions installed on Mac.
Select the JDK version to use. You should set this in your
.bash_profile
file. Replace below<JavaVersion>
with what was listed above.App Build Test:
Module Build Test:
CD
to directory:./ti.imagefactory/android
appc run -p android
Hyperloop Build Test: