Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove JSON from documentation #11479

Merged
merged 3 commits into from
Mar 5, 2020

Conversation

drauggres
Copy link
Contributor

The global JSON object is part of ECMA-262 specification (5th edition).

@janvennemann tidev/docs-devkit#25 (comment):

Agreed, we should remove JSON from our docs since it's part of the ECMA spec. Users can refer to JSON on MDN for example.

Related ticket: https://jira.appcelerator.org/browse/TIDOC-211 (15/Apr/2011)

global JSON object is a part of ECMA-262 standart (5.1 edition)
https://www.ecma-international.org/ecma-262/5.1/#sec-15.12
@build build added this to the 9.1.0 milestone Feb 17, 2020
@build build requested a review from a team February 17, 2020 10:51
@build
Copy link
Contributor

build commented Feb 17, 2020

Warnings
⚠️

Commit 21677d1517a290fa093e0310301ac8a4b817ce6d has a message "docs: remove JSON from documentation

global JSON object is a part of ECMA-262 standart (5.1 edition)
https://www.ecma-international.org/ecma-262/5.1/#sec-15.12" giving 1 warnings:

  • footer must have leading blank line
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, drauggres! Thanks again for helping us make Titanium SDK better. 👍
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖

✅ All tests are passing
Nice one! All 6555 tests are passing.
(There are 703 skipped tests not included in that total)

Generated by 🚫 dangerJS against 2ecb8e9

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn, totally missed this. The description property in Global.yml still contains a reference to the JSON docs. Please remove that section as well.

@drauggres drauggres requested review from janvennemann and removed request for a team February 19, 2020 08:21
@janvennemann janvennemann merged commit cc1b055 into tidev:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants