fix(ios): allow changing WebView read access when loading local file #11431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build
reviewed
Jan 14, 2020
| /* eslint no-unused-expressions: "off" */ | ||
| 'use strict'; | ||
| var should = require('./utilities/assertions'), | ||
| utilities = require('./utilities/utilities'); |
There was a problem hiding this comment.
⚠️ tests/Resources/ti.ui.webview.addontest.js line 11 – 'utilities' is assigned a value but never used. (no-unused-vars)
Tests:
|
|
@vijaysingh-axway I was wondering, how does the Unit test verify the new property? I don't see any test HTML files or anything that actually try to load something from a parent directory for example that require |
|
@janvennemann Updated unit test. |
janvennemann
requested changes
Jan 20, 2020
| var resourceDir = Ti.Filesystem.getFile(Ti.Filesystem.resourcesDirectory); | ||
|
|
||
| var htmlFile = Ti.Filesystem.getFile(Ti.Filesystem.resourcesDirectory, 'html', 'example.html'); | ||
| var cssFile = Ti.Filesystem.getFile(Ti.Filesystem.resourcesDirectory, 'folder with spaces', 'comingSoon.html'); |
There was a problem hiding this comment.
This is not a CSS file, update the variable name to avoid confusion.
| var cssFile = Ti.Filesystem.getFile(Ti.Filesystem.resourcesDirectory, 'folder with spaces', 'comingSoon.html'); | ||
|
|
||
| var htmlInCache = Ti.Filesystem.getFile(cacheDir.nativePath, 'html', 'example.html'); | ||
| var cssInCache = Ti.Filesystem.getFile(cacheDir.nativePath, 'folder with spaces', 'comingSoon.html'); |
There was a problem hiding this comment.
Also not a CSS file, update the variable name to avoid confusion.
build
reviewed
Jan 21, 2020
| /* eslint-env mocha */ | ||
| /* eslint no-unused-expressions: "off" */ | ||
| 'use strict'; | ||
| var should = require('./utilities/assertions'), |
There was a problem hiding this comment.
⚠️ tests/Resources/ti.ui.webview.addontest.js line 10 – 'should' is assigned a value but never used. (no-unused-vars)
janvennemann
approved these changes
Jan 22, 2020
|
FR Passed. Studio Ver: 6.0.0.201911251516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-27159