Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): ui glitch in lazyloading fixed #11418

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build
Copy link
Contributor

build commented Jan 9, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 710 skipped out of 7334 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation#reverseGeocoder()0.831
Error: expected 'United States of America' to equal 'USA'
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:287:35)
ios.ipad.Titanium.Geolocation#reverseGeocoder()0.959
Error: expected 'United States of America' to equal 'USA'
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/480970E5-608F-4ABF-9DFE-32A4D2DCE2C8/data/Containers/Bundle/Application/30C870C1-8350-4ADD-8D2E-66FB3F03A6FE/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/480970E5-608F-4ABF-9DFE-32A4D2DCE2C8/data/Containers/Bundle/Application/30C870C1-8350-4ADD-8D2E-66FB3F03A6FE/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/480970E5-608F-4ABF-9DFE-32A4D2DCE2C8/data/Containers/Bundle/Application/30C870C1-8350-4ADD-8D2E-66FB3F03A6FE/mocha.app/ti.geolocation.test.js:287:38

Generated by 🚫 dangerJS against 7721243

@ssjsamir ssjsamir self-requested a review January 9, 2020 16:01
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Tested using the the test case mentioned in: https://jira.appcelerator.org/browse/TIMOB-27158

Test Environment

MacOS Catalina 10.15.1 beta
Xcode 11.3
Node.js 10.16.3
"NPM":"4.2.15-1","CLI":"7.1.2-7"
iPhone 8 Sim (ios 13.3)

@sgtcoolguy sgtcoolguy added this to the 8.3.1 milestone Jan 9, 2020
@sgtcoolguy sgtcoolguy merged commit a32f713 into tidev:8_3_X Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants