Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): expose TiApp singleton accessor to swift #11363

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

janvennemann
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27622

Optional Description:
The default singleton property app from Objective-C is ignored by Swift due to naming conventions. Renaming it to sharedApp() makes it available in Swift as well.

@build
Copy link
Contributor

build commented Nov 22, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6623 tests are passing.
(There are 711 skipped tests not included in that total)

Generated by 🚫 dangerJS against d5f178a

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ssekhri
Copy link

ssekhri commented Dec 2, 2019

FR Passed.
Verified on:
Mac OS: 10.15.1
SDK: 9.0.0.v20191122141709
Ti CLI: 5.2.2
JDK: 11.0.4
Node: 10.16.3
Xcode: 11.2

@ssekhri ssekhri merged commit 495d76c into tidev:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants