Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Ti.UI.View.id property #11353

Merged
merged 2 commits into from
Nov 21, 2019
Merged

docs: add Ti.UI.View.id property #11353

merged 2 commits into from
Nov 21, 2019

Conversation

drauggres
Copy link
Contributor

Property id of Ti.UI.View is not documented.

@drauggres
Copy link
Contributor Author

Since we already have Ti.UI.View.getViewById method, I think it wouldn't be wrong to consider id property as a legal part of the API.

@build build added this to the 9.0.0 milestone Nov 20, 2019
@build build requested a review from a team November 20, 2019 15:56
@build
Copy link
Contributor

build commented Nov 20, 2019 •
edited
Loading

Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖

💾 Here's the generated SDK zipfile.
📖 🎉 Another contribution from our awesome community member, drauggres! Thanks again for helping us make Titanium SDK better. 👍
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6625 tests are passing.
(There are 709 skipped tests not included in that total)

Generated by 🚫 dangerJS against df71c9c

@drauggres drauggres mentioned this pull request Nov 20, 2019
Closed
sgtcoolguy
sgtcoolguy suggested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small tweak to doc text.

This looks good to me. We don't have specialized methods for this property, but as you state we have getViewById which makes use of the optional id property. It should likely be official API.

apidoc/Titanium/UI/View.yml Outdated Show resolved Hide resolved
@drauggres @sgtcoolguy
docs: fix Ti.UI.View.id description
df71c9c 
Co-Authored-By: Christopher Williams <chris.a.williams@gmail.com>
@sgtcoolguy sgtcoolguy merged commit b295e63 into tidev:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy requested changes

Assignees
No one assigned
Labels
community 🔥 docs
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@drauggres @build @sgtcoolguy